[FFmpeg-devel] [PATCH] Add the function libavcodec/utils.c:avcodec_type_string

[Michael Niedermayer]

On Mon, Apr 07, 2008 at 03:16:03PM +0200, Stefano Sabatini wrote:
> On date Monday 2008-04-07 11:56:18 +0100, M?ns Rullg?rd encoded:
> > 
> > Stefano Sabatini wrote:
> > > On date Wednesday 2007-11-21 09:58:35 +0100, Stefano Sabatini encoded:
> > >> On date Monday 2007-11-12 09:53:39 +0100, Stefano Sabatini encoded:
> > >> > On date Friday 2007-11-09 15:26:22 +0100, Stefano Sabatini encoded:
> > >> > > On date Friday 2007-11-09 11:34:25 +0100, Stefano Sabatini encoded:
> > >> > > > On date Friday 2007-11-09 09:00:05 +0000, M?ns Rullg?rd encoded:
> > >> > > [...]
> > >> > > > > Why don't you declare the argument as type CodecType?  That should
> > >> > > > > make it abundantly clear what is expected.
> > >> > > > >
> > >> > > > > Also, why do you use snprintf() here, when av_strlcpy() would do just
> > >> > > > > as well, or even simply returning the string constants.
> > >> > > > [...]
> > >> > > >
> > >> > > > Yes, it looks like a simpler solution, which I prefer over the
> > >> > > > previous ones.
> > > [...]
> > >
> > > Hi, a patch which come back from a distant past, readjusted against the
> > > latest SVN.
> > 
> > The prototype and definition of the new function don't match.
> 
> Ops, fixed (also fixed the "unknwon" typo and eliminated the
> redundancies in the documentation).

I would like to keep the API simple and not bloat it with a function
to convert every enum to a string.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080407/1f56cfd2/attachment.pgp>