[FFmpeg-devel] [PATCH] Add the function libavcodec/utils.c:avcodec_type_string

[Måns Rullgård]

Stefano Sabatini wrote:
> On date Wednesday 2007-11-21 09:58:35 +0100, Stefano Sabatini encoded:
>> On date Monday 2007-11-12 09:53:39 +0100, Stefano Sabatini encoded:
>> > On date Friday 2007-11-09 15:26:22 +0100, Stefano Sabatini encoded:
>> > > On date Friday 2007-11-09 11:34:25 +0100, Stefano Sabatini encoded:
>> > > > On date Friday 2007-11-09 09:00:05 +0000, M?ns Rullg?rd encoded:
>> > > [...]
>> > > > > Why don't you declare the argument as type CodecType?  That should
>> > > > > make it abundantly clear what is expected.
>> > > > >
>> > > > > Also, why do you use snprintf() here, when av_strlcpy() would do just
>> > > > > as well, or even simply returning the string constants.
>> > > > [...]
>> > > >
>> > > > Yes, it looks like a simpler solution, which I prefer over the
>> > > > previous ones.
> [...]
>
> Hi, a patch which come back from a distant past, readjusted against the
> latest SVN.

The prototype and definition of the new function don't match.

-- 
M?ns Rullg?rd
mans at mansr.com