[FFmpeg-devel] [PATCH] [2/??] [3/3] Filter graphs - Parser for a graph description

[Michael Niedermayer]

On Thu, Apr 03, 2008 at 06:54:29PM +0200, Vitor Sessak wrote:
> Hi, and thanks for the review
[...]
> (... review skipped ...)
>
> All good points. New version attached.
[...]
> void avfilter_graph_add_filter(AVFilterGraph *graph, AVFilterContext *filter)
> {
>     graph->filters = av_realloc(graph->filters,
>                                 sizeof(AVFilterContext*) * ++graph->filter_count);
>     graph->filters[graph->filter_count - 1] = filter;

Out of array write


[...]
> static int query_formats(AVFilterGraph *graph)
> {
>     int i, j;
>     int scaler_count = 0;
>     char inst_name[30];
[...]
>                     /* couldn't merge format lists. auto-insert scale filter */
>                     snprintf(inst_name, 30, "auto-inserted scaler %d",
>                              scaler_count);

sizeof(inst_name)


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080403/a1205dec/attachment.pgp>