[FFmpeg-devel] [RFC] comment mpegvideo_split

[Baptiste Coudurier]

Hi,

Michael Niedermayer wrote:
> On Wed, Mar 19, 2008 at 04:11:37PM +0100, Baptiste Coudurier wrote:
>> Baptiste Coudurier wrote:
>>> Michael Niedermayer wrote:
>>>> On Tue, Mar 18, 2008 at 01:16:34AM +0100, Baptiste Coudurier wrote:
>>>>> Hi,
>>>>>
>>>>> Currently, mpegvideo split function causes problems with containers
>>>>> setting AVFMT_GLOBAL_HEADER, mov and mp4 in particular, because
>>>>> MPEG-1/2 in those containers are to be muxed normally.
>>>>>
>>>>> I don't know any particular usage of the mpegvideo split function, so I
>>>>> tend to want to comment it, to finally fix this issue.
>>>>>
>>>>> Anyone see another better alternative ?
>>>> After a few more seconds :)
>>>> The muxers could just dump extradata for the case of mpeg1/2 before keyframes,
>>>> that should fix it i think. Its of course a little odd to first extract and
>>>> then put it back in the muxer.
>>>>
>>> Would the attached patch be ok ?
>>>
>> This one is more correct, messy though.
>>
>> [...]
>>  
>> +    if (dump_extradata) {
>> +        put_buffer(pb, trk->vosData, trk->vosLen);
>> +        size -= trk->vosLen;
>> +    }
>>      put_buffer(pb, pkt->data, size);
>>  
>>      put_flush_packet(pb);
> 
> ok, its not beautifull but i dont know a better solution. Maybe some
> auto insertion of a bitstream filter, that could also be usefull to
> simplify other cases ...
> Anyway i think its better to commit this, we can always revert it if
> someone does find a better solution.
> 

I was thinking about this other solution, and it seems to work, though
It acts a bit behind the user's back.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG SAS                                     http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mpeg2_global_header.patch
Type: text/x-diff
Size: 1659 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080403/8591cf54/attachment.patch>