[FFmpeg-devel] [PATCH] eliminate long from ByteIOContext structure

[Michael Niedermayer]

On Wed, Apr 02, 2008 at 09:04:47PM +0200, Diego Biurrun wrote:
> On Wed, Apr 02, 2008 at 11:30:50AM +0200, Reimar D?ffinger wrote:
> > On Wed, Apr 02, 2008 at 09:19:45AM +0200, Diego Biurrun wrote:
> > > +unsigned long get_checksum(ByteIOContext *s);
> > > +#if LIBAVFORMAT_VERSION_MAJOR >= 53
> > > +unsigned long ff_crc04C11DB7_update(unsigned int checksum, const uint8_t *buf, unsigned int len);
> > > +void init_checksum(ByteIOContext *s, unsigned int (*update_checksum)(unsigned int c, const uint8_t *p, unsigned int len), unsigned int checksum);
> > > +#else
> > >  unsigned long ff_crc04C11DB7_update(unsigned long checksum, const uint8_t *buf, unsigned int len);
> > > -unsigned long get_checksum(ByteIOContext *s);
> > 
> > Hm, should get_checksum and ff_crc04C11DB7_update really continue to
> > return unsigned long?
> 
> .. next try ..
[...]
> +#if LIBAVFORMAT_VERSION_MAJOR >= 53
> +uint32_t ff_crc04C11DB7_update(unsigned int checksum, const uint8_t *buf, unsigned int len);
   ^^^^^^^^

And iam sure there are more things you should to change to int

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is not what we do, but why we do it that matters.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20080403/4e2a4a21/attachment.pgp>