[FFmpeg-devel] [PATCH] check read_packet before calling it

Michael Niedermayer michaelni
Wed Sep 26 10:47:42 CEST 2007


Hi

On Wed, Sep 26, 2007 at 09:18:42AM +0200, Benoit Fouet wrote:
> Hi,
> 
> Michael Niedermayer wrote:
> > Hi
> >
> > On Tue, Sep 25, 2007 at 08:51:33PM +0200, Benoit Fouet wrote:
> >   
> >> Hi,
> >>
> >> attached is a patch to $subj
> >>     
> >
> > can you elaboarte a little on when read_packet is null
> 
> when it is not set in init_put_byte
> 
> >  and why
> > changing fill_buffer to not fill anything is the correct behavior
> >
> >   
> 
> well, if no read packet function is provided, we can not fill buffer

and under which circumstances is fill_buffer() called in such a case?

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070926/6a39b265/attachment.pgp>



More information about the ffmpeg-devel mailing list