[FFmpeg-devel] [PATCH] AVI files with On2 headers
Aurelien Jacobs
aurel
Tue Sep 25 17:16:03 CEST 2007
On Tue, 25 Sep 2007 11:20:02 +0100 (BST)
M?ns Rullg?rd <mans at mansr.com> wrote:
>
> Aurelien Jacobs wrote:
> > Hi,
> >
> > The attached patch add support for On2 variation of the AVI header.
>
> Hmm... where did I put my shotgun?
>
> > Sample to test it: http://samples.mplayerhq.hu/V-codecs/VP5/Cell-140.vp5
> > Is this patch OK ?
>
> The patch looks reasonably clean, but I'm not AVI maintainer (thank
> goodness). That said, if there are more variants like this around,
> I'd prefer a table-based solution.
I tend to like such kind of tables, so here is a new version of the
patch. It is more intrusive, but resulting code is nicer IMO.
And it will simplify the incoming patch which adds AMV files support.
So is this new patch OK ?
If not, I will apply initial version of the patch.
Aurel
More information about the ffmpeg-devel
mailing list