[FFmpeg-devel] [PATCH] configure - organize

Ivo ivop
Wed Sep 19 11:47:30 CEST 2007


On Wednesday 19 September 2007 01:35, M?ns Rullg?rd wrote:
> Ramiro Polla <ramiro at lisha.ufsc.br> writes:
> > M?ns Rullg?rd wrote:
> >> Ramiro Ribeiro Polla <ramiro at lisha.ufsc.br> writes:
> >>> Hello,
> >>>
> >>> configure1.diff adds some comments to organize configure. I'd prefer
> >>> if they were 80 columns wide though.
> >>
> >> I find such banners exceedingly ugly.
> >
> > And I think the lack of banners makes understanding configure
> > unnecessarily hard. I'm pretty sure I'm not alone when I want to add
> > something to configure but have no idea where's the best place to put
> > it. Sure, I've been reading it for more than a year, so I know my way
> > around a little bit more.
> >
> > They may be ugly, but they're better to organize configure in logical
> > blocks. I find those single-lined # check x explanations not enough. I
> > have to read each check again and again to see what is it that they are
> > doing.
> >
> > I don't have any preference for the style in division. Do you think you
> > could find a way that you like so it's easier to divide configure?
>
> I like them absent.  If you find single-line comments hard to read,
> consider fixing your editor to highlight them better.

Perhaps there can be a consensus on something like:

# This is a comment ----------------------------------

or 

# ----------( Some Section )-------------------

or something similar.

It stays single-line but has the ruler built-in so to say. I must say that 
for each and every comment, I don't like banners or rulers, but for clear 
separation of sections, I can understand its use (and use it myself).

--Ivo




More information about the ffmpeg-devel mailing list