[FFmpeg-devel] [PATCH] configure - organize

Måns Rullgård mans
Tue Sep 18 22:38:09 CEST 2007


Ramiro Ribeiro Polla <ramiro at lisha.ufsc.br> writes:

> Hello,
>
> configure1.diff adds some comments to organize configure. I'd prefer
> if they were 80 columns wide though.

I find such banners exceedingly ugly.

> configure2.diff reorganizes a bunch of system header file and function
> checks to a common place.

Looks mostly OK, but please lose the ugly banner.  Maybe split this in
a few steps too.

> Also, may I indent configure to 4 spaces? There are still some parts
> with 2 space indents.
>
> Ramiro Polla
> Index: configure
> ===================================================================
> --- configure	(revision 10532)
> +++ configure	(working copy)
> @@ -1611,6 +1611,9 @@
>  
>  check_func fork
>  
> +##########################################
> +# vhook check
> +

Ugly.

-- 
M?ns Rullg?rd
mans at mansr.com




More information about the ffmpeg-devel mailing list