[FFmpeg-devel] [PATCH] fix swf playback with bad audio track

[Aurelien Jacobs]

On Sun, 16 Sep 2007 17:47:35 +0200
Michael Niedermayer <michaelni at gmx.at> wrote:

> Hi
> 
> On Sun, Sep 16, 2007 at 05:31:53PM +0200, Aurelien Jacobs wrote:
> [...]
> > > Now concerning the sample, it uses DEFINESOUND tag which is a block a
> > > sound data, ie all mp3 frames are in one block, so demuxer must
> > > interleave those frames with video frames. This is not supported atm.
> > 
> > Second attached patch implement support for DEFINESOUND.
> > Audio packetizing and interleaving is ugly, but at least it
> > works for the sample mentioned in this tread.
> 
> what are you guys doing? dont tell me you split variable size mp3 packets
> with the assumtation that they are not variable (CBR mp3 has variable sized
> packets yes, they differ by +-1 byte to achive the exact bitrate)

Even worse... I split mp3 packets at random boundaries !

> and secondly which is more important, we have an AVParser which when
> activated (see needs_parsing) will split the packets for you

Indeed, and it is already enabled in swf. That's the AVParser which
reconstruct proper packets out of my randomly split packets.
Well, I said it was a ugly hack, which just demonstrated how to decode
DEFINESOUND. Nothing more.

Aurel