[FFmpeg-devel] [PATCH] NellyMoser audio decoder

[Rich Felker]

On Tue, Sep 11, 2007 at 02:13:36PM +0200, Reimar D?ffinger wrote:
> Hello,
> On Tue, Sep 11, 2007 at 02:55:07PM +0300, Uoti Urpala wrote:
> > On Tue, 2007-09-11 at 13:49 +0200, Reimar D?ffinger wrote:
> > > Also you can't have values like 31355 in an array of shorts, either it
> > > must be uint16_t (or if you insist unsigned short) or int, or they
> > > should be written as the right signed values if they are used as signed.
> > 
> > Why not? Your text sounds as if you thought 31355 was too large for a
> > 16-bit signed short, but it obviously isn't.
> 
> yes, forget that part. Happens when you don't take your time...
> Btw. would others prefer int16_t instead of short as well? I like it
> better and I think it is more consistent with other ffmpeg code.
> In addition it might be worth to check if those tables are better created
> at runtime...

Runtime creation of tables is bad. If we could get rid of all the
runtime tables it would be a big step forward for anti-bloat,
simplicity, and preventing memleak issues in corner cases. (The other
approaches aside from including tables directly in the source cause
additional memory usage per-process and possibly memory leaks with
libdl loading.)

Rich