[FFmpeg-devel] [PATCH] Re-add OS/2 support

[KO Myung-Hun]

Hi/2.

Diego Biurrun wrote:
> On Sat, Sep 08, 2007 at 04:37:44PM +0900, KO Myung-Hun wrote:
>   
>> This patch re-add OS/2 support.
>>
>> --- configure	(revision 10425)
>> +++ configure	(working copy)
>> @@ -696,6 +718,7 @@
>>      mkstemp
>>      mlib
>> +    os2
>>     
>
> This is unused and unnecessary.
>
>   
>> @@ -1199,6 +1223,27 @@
>>      targetos=irix
>>      ranlib="echo ignoring ranlib"
>>      ;;
>> +  os/2*)   
>> +    TMPE=$TMPE".exe"   
>>     
>
> This should rather be made part of the TMPE definition.
>
>   
>> +    FFSERVERLDFLAGS=""     
>> +    ffserver="no"  
>>     
>
> nonsense
>
>   
>> +    pkg_requires=""    
>>     
>
> nonsense
>
>   
>> +    dv1394="no"    
>>     
>
> redundant
>
>   
>> +    os2="yes"  
>>     
>
> see above
>
>   

I think, Dave Yeo suggested a good patch for the above.
>> @@ -1641,7 +1686,7 @@
>>      temp_extralibs `"${SDL_CONFIG}" --libs`
>> -    if check_lib SDL.h SDL_Init; then
>> +    if check_lib2 SDL.h SDL_Init; then
>>     
>
> This looks wrong.
>
>   

check_lib() check header and function independently and assume function 
type is 'int', but check_lib2() check function with given header. In 
OS/2 port of SDL, the naming convention of SDL function is not a C 
convention, preceded by '_'. But it is named as it is. That is, 
'SDL_Init' is 'SDL_Init' not '_SDL_Init'. So without 'SDL.h' linker find 
'_SDL_Init', but lib has a 'SDL_Init'. After all, linker faile to link.

So I choosed check_lib2.

> Also, there is a ton of trailing whitespace.
>
>   

Although I said in another thread, what is trailing whitespace ? CR ? Or...

> Patch in its current form is rejected.
>
>   

It's very good to express whether 'accepted' or 'rejected' explicitly

-- 
KO Myung-Hun

Using Mozilla SeaMonkey 1.1.4
Under OS/2 Warp 4 for Korean with FixPak #15
On AMD ThunderBird 750 MHz with 512 MB RAM

Korean OS/2 User Community : http://www.ecomstation.co.kr