[FFmpeg-devel] [PATCH] Cleanup for audio grabbing interface and build system

Rich Felker dalias
Mon Sep 10 19:41:34 CEST 2007


On Mon, Sep 10, 2007 at 07:04:16PM +0200, Diego Biurrun wrote:
> On Thu, Sep 06, 2007 at 05:46:13PM -0300, Ramiro Polla wrote:
> > 
> > Diego Biurrun wrote:
> > > This reminds me that the file should really be renamed to oss.c.
> > 
> > This is what audio4.diff does along with svn mv audio.c oss.c
> > 
> > > Or maybe it would be better to call it audio_oss.c and rename the
> > > (de)muxer accordingly?
> > 
> > I renamed grab_bktr.c to bktr.c, but maybe it wasn't the best option. We 
> > should decide a name for new grab interfaces to be consistent.
> > What about grab_ for all of them? Or grab, without the undernline, like 
> > in the libs. Or put them in a different/separate folder?
> 
> I prefer grab_.  libavgrab would also be an option.

IMO all grabbing should be in a separate library, on which libavformat
does not depend, with its own "register" function that you can call to
register the grabbers with avformat. This way programs that just need
demuxing would not pull in dependencies on all sorts of grabbers. I
can just imagine in the future having grabbers based on bloated
digital camera grabbing software or even libsane, and the debian
packages pulling in these dependencies for every program that uses
libavformat....

Rich




More information about the ffmpeg-devel mailing list