[FFmpeg-devel] [PATCH] h264 parallelized

[Robert Swain]

Hello,

On 5 Sep 2007, at 15:26, Guillaume Poirier wrote:
> Andreas ?man wrote:
>> Diego Biurrun wrote:
>>> On Tue, Sep 04, 2007 at 03:18:13PM +0200, Andreas ?man wrote:
>>>> Correct, I googled around and found some grouping examples in the
>>>> doxygen manual.
>>>>
>>>> Rest of the stuff should be fixed.
>>>>
>>>> --- libavcodec/h264.c    (revision 10288)
>>>> +++ libavcodec/h264.c    (working copy)
>>>> @@ -2907,6 +2911,46 @@
>>>>
>>>> +/**
>>>> + * mimic alloc_tables(), but for every context thread
>>>
>>> nit: Capitalize, add period.
>>
>> Fixed
>
> [..]
>
>
> Your patch doesn't link:
>
> gcc -L"/scratch/gpoirier/snapshot/ffmpeg-svn"/libavformat
> -L"/scratch/gpoirier/snapshot/ffmpeg-svn"/libavcodec
> -L"/scratch/gpoirier/snapshot/ffmpeg-svn"/libavutil -pthread -rdynamic
> -export-dynamic -Wl,--warn-common -Wl,--as-needed
> -Wl,-rpath-link,"/scratch/gpoirier/snapshot/ffmpeg-svn"/libavcodec
> -Wl,-rpath-link,"/scratch/gpoirier/snapshot/ffmpeg-svn"/libavformat
> -Wl,-rpath-link,"/scratch/gpoirier/snapshot/ffmpeg-svn"/libavutil -g
> -o ffmpeg_g ffmpeg.o cmdutils.o -lavformat -lavcodec -lavutil -lm - 
> lz -ldl
> /scratch/gpoirier/snapshot/ffmpeg-svn/libavcodec/libavcodec.a(h264.o):
> In function `clone_tables':
> /scratch/gpoirier/snapshot/ffmpeg-svn/libavcodec/h264.c:2170:
> undefined reference to `init_pred_ptrs'
> collect2: ld returned 1 exit status
> make: *** [ffmpeg_g] Error 1
>
> I configured with:
> ./configure --enable-gpl --cpu=nocona --enable-pthreads
>
> I have the same problem with and without --enable-pthreads

This is no doubt because of Kostya's commit of r10397 but this will  
need updating. :)

Rob