[FFmpeg-devel] AAC support in SDP

Michael Niedermayer michaelni
Mon Sep 3 19:11:17 CEST 2007


Hi

On Mon, Sep 03, 2007 at 03:03:39PM +0200, Luca Abeni wrote:
> Hi Luca,
> 
> thanks for the comments
> 
> Luca Barbato wrote:
> [...]
> > +static char *config_prepare(const uint8_t *extradata, int extradata_size)
> > +{
> > +    char *config;
> > +
> > 
> > isn't a bit generic name?
> 
> Well, this is the best name I could invent ;-) (since the function is 
> preparing a "config=" attribute, it looked like the logical name)
> But if there are better proposals, I have no problems in changing it (is 
> the "config=" attribute mpeg4-specific? If yes, the function name could 
> be mpeg4_config_prepare())

hmm

build_config_from_extradata
build_config_string_from_extradata
build_config_string
extradata2config_str
gbl_header_to_string
extradata2str
...

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I wish the Xiph folks would stop pretending they've got something they
do not.  Somehow I fear this will remain a wish. -- M?ns Rullg?rd
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20070903/bcccf26f/attachment.pgp>



More information about the ffmpeg-devel mailing list