[FFmpeg-devel] [PATCH] h264 bitstream filter

[Benoit Fouet]

Aurelien Jacobs wrote:
> On Mon, 03 Sep 2007 15:15:29 +0200
> Benoit Fouet <benoit.fouet at purplelabs.com> wrote:
>
>   
>> M?ns Rullg?rd wrote:
>>     
>>> Benoit Fouet wrote:
>>>   
>>>       
>>>> M?ns Rullg?rd wrote:
>>>>     
>>>>         
>>>>> Michael Niedermayer wrote:
>>>>>
>>>>>       
>>>>>           
>>>>>> On Mon, Sep 03, 2007 at 10:10:04PM +1000, mark cox wrote:
>>>>>>
>>>>>>         
>>>>>>             
>>>>>>> On 03/09/07, Benoit Fouet <benoit.fouet at purplelabs.com> wrote:
>>>>>>>
>>>>>>>           
>>>>>>>               
>>>>>>>> mark cox wrote:
>>>>>>>>
>>>>>>>>             
>>>>>>>>                 
>>>>>>>>>> if someone has a better name for this filter, i'd be happy to apply it
>>>>>>>>>> too :)
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>                 
>>>>>>>>>>                     
>>>>>>>>> How would you explain what it does in english?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>               
>>>>>>>>>                   
>>>>>>>> it converts h264 encapsulated in ISO base media file format to h264
>>>>>>>> elementary stream.
>>>>>>>> it seems a bit long as a name :)
>>>>>>>>
>>>>>>>> i don't know if avc is used only for h264 in 'mp4' container or not...
>>>>>>>> if it is so, maybe a name like: avc_to_h264 could be used ?
>>>>>>>> i must admit i don't really know what to use...
>>>>>>>>
>>>>>>>>             
>>>>>>>>                 
>>>>>>> h264_iso_to_h264_es ?
>>>>>>> h264_mp4_to_h264_es ?
>>>>>>>
>>>>>>>           
>>>>>>>               
>>>>>> h264_iso2es ?
>>>>>> h264_mp4_to_es ?
>>>>>>
>>>>>>         
>>>>>>             
>>>>> The term "elementary stream" is not formally defined in relation to H.264.
>>>>>
>>>>>       
>>>>>           
>>>> do you feel "h264_iso2es" is correct enough to be used in ffmpeg ?
>>>>     
>>>>         
>>> Both input and output are ISO formats, and ES is not defined, so no,
>>> I don't think that's a good name.
>>>
>>>   
>>>       
>> what about h264_mp4toannexB ?
>> (and please, if you have a suggestion, feel free to share it)
>>     
>
> I haven't read the code and I don't know much about the subject,
> but from previous discussion, here is what comes to my mind:
>   h264_nal2annexB
> Well, annexB is not a very nice name, but if there is no better name
> clearly associtated to this, then just use annexB.
>
>   

what is described in annex B is also NAL units
so i don't think this name will fit neither...

-- 
Ben
Purple Labs S.A.
www.purplelabs.com