[FFmpeg-devel] [PATCH] Make RTP work with IPv6 enabled

[Luca Abeni]

Hi Ronald,

Ronald S. Bultje wrote:
[...]
>> +    if (((struct sockaddr *) &s->dest_addr)->sa_family)
>> +        family = ((struct sockaddr *) &s->dest_addr)->sa_family;
>> +    res0 = udp_ipv6_resolve_host(0, s->local_port, SOCK_DGRAM, family,
>> AI_PASSIVE);
>>
>> Right? I agree that this looks the correct thing to do, and I guess it
>> should be committed.
>
> Also the malloc->mallocz(), otherwise it is not initialized to zero and
> random stuff may happen.
Ok, thanks. Things are more clear now :)

Unfortunately, I've been preempted by some serious issues at work...
I do not know if I'll be able to look at this stuff until next week :(

Anyway, now that we have an explanation for the strange macos x behaviour
I think things are beginning to make sense.

I suppose that the "bind patch" from Nicolas and the change above can
be committed.
I'll commit them on Monday unless anyone complains.
After that, we'll start commit the following patches.

[...]
> Yes, correct, the rtpproto.c appears unneeded, sorry for that.
No problem. I was just confused about it.

> Need a new patch or will you commit as-is?

I do not think a new patch is needed (just point me to the last version
of Nicolas patch, because I lost it).


			Thanks,
				Luca