[FFmpeg-devel] [PATCH] MLP/TrueHD decoder

[Michael Niedermayer]

Hi

On Tue, Oct 23, 2007 at 09:06:18AM +0100, Ian Caulfield wrote:
> Hi,
> 
> On 22/10/2007, Michael Niedermayer <michaelni at gmx.at> wrote:
> >
> > its not the parsers job to check frames
> > the only reason for a parser to not return part of the input is if it cannot
> > determine the frame boundaries (for example if the frame length from some
> > header is invalid/damaged)
> 
> The reasoning behind this was that MLP streams are a pain to parse -
> most frames contain no sync word, just a length at the start of the
> frame. There appears to be no protection against sync word emulation.
> Without checking the frame parity nibble, there's no way to tell if
> the stream was corrupted and the parser is now out of sync with the
> stream - if this happens the parser will just return garbage frame
> boundaries until the end of the stream.

well then leave that parity check in there

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071029/572da261/attachment.pgp>