[FFmpeg-devel] [PATCH] ogg muxer

Aurelien Jacobs aurel
Sun Oct 28 23:01:46 CET 2007


M?ns Rullg?rd wrote:

> Baptiste Coudurier <baptiste.coudurier at smartjog.com> writes:
> 
> > M?ns Rullg?rd wrote:
> >> Baptiste Coudurier <baptiste.coudurier at smartjog.com> writes:
> >>>
> >>>+            av_set_pts_info(st, 64, st->codec->time_base.num, st->codec->time_base.den);
> >> 
> >> 
> >> Please try to keep lines less than 80 characters in length.
> >
> > I prefer not to split lines at 80 columns when lines are reasonably long
> > but please I see no point starting to troll about it.
> 
> I personally find lines that don't wrap much easier to read.  That
> said, I do make exceptions when there is no natural place to split the
> line.

Here I agree with Mans (and also with Baptiste, as long as "reasonably long"
means <= 80).

> All else aside, you've forgotten to update allformats.c

Because there's nothing to update in allformats.c...

Aurel




More information about the ffmpeg-devel mailing list