[FFmpeg-devel] [PATCH] move av_crc04C11DB7_update to libavutil

[Michael Niedermayer]

Hi

On Sun, Oct 28, 2007 at 06:51:19PM +0100, Baptiste Coudurier wrote:
> Hi
> 
> $subject. Needed to avoid code duplication for new ogg muxer.
> 
> -- 
> Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
> SMARTJOG S.A.                                    http://www.smartjog.com
> Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
> Phone: +33 1 49966312

> Index: libavutil/crc.c
> ===================================================================
> --- libavutil/crc.c	(revision 10867)
> +++ libavutil/crc.c	(working copy)
> @@ -105,6 +105,10 @@
>      return crc;
>  }
>  
> +unsigned long av_crc04C11DB7_update(unsigned long checksum, const uint8_t *buf, unsigned int len){
> +    return av_crc(av_crc04C11DB7, checksum, buf, len);
> +}
> +
>  #ifdef TEST
>  #undef printf
>  main(){

libavutil is not supposed to be a place for code common between libavcodec
and libavformat, even less so between 2 libavformat (de)muxers! but rather
a small lib of generally usefull things av_crc04C11DB7_update() is not
usefull outside of libavformat

so this function should stay in libavformat 

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071028/0f699d9b/attachment.pgp>