[FFmpeg-devel] [PATCH] h264 - don't warn about deblocking type 1 without multiple slices

[Alexander Strange]

On Oct 27, 2007, at 3:18 PM, Michael Niedermayer wrote:

> Hi
>
> On Fri, Oct 26, 2007 at 05:40:01PM -0400, Alexander Strange wrote:
>> If you enable multithreaded decoding for h.264, you get the warning
>> "Cannot parallelize deblocking type 1, decoding such frames in  
>> sequential
>> order",
>> even if the video has only one slice and can't be parallelized  
>> anyway.
>>
>> This patch disables that bit of code for the first slice in a  
>> frame. I
>> tested it on
>> single-slice (that it can't parallelize) and multi-slice (that it  
>> can), but
>> not on
>> type 1 + multi-slice since I can't find any. Is there any on  
>> mplayerhq?
>
> this patch is wrong, it will disable the CODEC_FLAG2_FAST behavior of
> deblocking_filter == 1 slices
>
> [...]

Looking at the h264 spec, deblocking_filter 1 is the same as 2 on  
single-slice,
so I think it's safe to make that change on everything.

I found a sample at http://www.apple.com/quicktime/guide/hd/nasaspaceshuttle.html 
.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: h264-deblock-warning-2.diff
Type: application/octet-stream
Size: 898 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071028/643532bc/attachment.obj>
-------------- next part --------------