[FFmpeg-devel] [PATCH] do not write empty udta atom
Benoit Fouet
benoit.fouet
Wed Oct 24 12:27:11 CEST 2007
Baptiste Coudurier wrote:
> Benoit Fouet wrote:
>
>> Baptiste Coudurier wrote:
>>
>>> Hi Benoit,
>>>
>>> Benoit Fouet wrote:
>>>
>>>
>>>> Benoit Fouet wrote:
>>>>
>>>>
>>>>> Baptiste Coudurier wrote:
>>>>>
>>>>>
>>>>>
>>>>>> Benoit Fouet wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> ATM, movenc.c writes the udta atom even if it is empty.
>>>>>>> this patch checks that we have something to write before writing the atom.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> Why creating an empty atom for MODE_MOV ? Do it for all.
>>>>>> You forgot the libavformat ident.
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>> i also forgot the requirements... thanks for noticing
>>>>> updated patch attached.
>>>>>
>>>>>
>>>>>
>>>>>
>>>> ping ? Baptiste, Michael ?
>>>>
>>>>
>>>>
>>> req is for MODE_MOV only and LIBAVFORMAT_IDENT is also written for mp4
>>> currently.
>>>
>>>
>> at the moment, it is not, but this could be another patch...
>>
>>
>
> Seems LIBAVFORMAT_IDENT is only written for mp4 if any metadata is
> written, so ok.
>
>
LIBAVFORMAT_IDENT is only written in MODE_MOV ATM, and if not in
bitexact mode.
> Req is only needed for for MODE_MOV though.
>
indeed, typo fixed in the attached patch.
--
Ben
Purple Labs S.A.
www.purplelabs.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: movenc.c.diff
Type: text/x-patch
Size: 1826 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071024/534e33fb/attachment.bin>
More information about the ffmpeg-devel
mailing list