[FFmpeg-devel] [RFC] remove lrintf fallback implementation

[Måns Rullgård]

"V?ctor Paesa" <wzrlpy at arsystel.com> writes:

>>> +    asm
>>> +    ("fistpll %0"
>>> +    : "=m" (llrintres) : "t" (x) : "st");
>>
>> The formatting of this asm() statement is incredibly ugly.
>
> I must confess I am an asm-illiterate, for me every asm is ugly. I made
> another (mostly blind) attempt.

If you don't know assembler, how do you know this code is correct?

> +    asm(
> +        "fistpll %0" : "=m" (llrintres) : "t" (x) : "st"
> +    );

I, and I think most others, prefer writing it like this:

    asm("fistpll %0" : "=m" (llrintres) : "t" (x) : "st");

-- 
M?ns Rullg?rd
mans at mansr.com