[FFmpeg-devel] [PATCH] MMS protocol support patch 1

[Michael Niedermayer]

Hi

On Tue, Oct 09, 2007 at 02:24:58PM +0200, Bj?rn Axelsson wrote:
[...]> > [...]
> > 
> > > Index: libavformat/avformat.h
> > > ===================================================================
> > > --- libavformat/avformat.h	(revision 10573)
> > > +++ libavformat/avformat.h	(arbetskopia)
> > > @@ -21,8 +21,8 @@
> > >  #ifndef AVFORMAT_H
> > >  #define AVFORMAT_H
> > >  
> > > -#define LIBAVFORMAT_VERSION_INT ((51<<16)+(13<<8)+4)
> > > -#define LIBAVFORMAT_VERSION     51.13.4
> > > +#define LIBAVFORMAT_VERSION_INT ((52<<16)+(0<<8)+0)
> > > +#define LIBAVFORMAT_VERSION     52.0.0
> > >  #define LIBAVFORMAT_BUILD       LIBAVFORMAT_VERSION_INT
> > 
> > ahh, great, theres no easy way to avoid that i guess?
> > these additions in ByteIOContext and its use in AVFormatContext :(
> > maybe we should think about if we at least can correct the code so
> > similar extensions in the future wont require a major version bump
> 
> I'm not sure what you mean here. I guess that you mean that protocol API
> additions need new fields in several structs and break the ABI.
> 
> How about implementing something similar to ioctl() for this kind of
> functionality?

i was more thinking of
AVFormatContext{
    ByteIOContext *pb;

instead of
AVFormatContext{
    ByteIOContext pb;

that said ill review everything which gets posted, if some other system
is equally clean, simple and readable and also solves the ABI issues with
adding fields to structs then thats all fine. i just dont think theres
another equally simple and clean solution

what i will certainly not accept is something based on hypothetical
advantages, that is things we never needed or wanted to do in the past

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

it is not once nor twice but times without number that the same ideas make
their appearance in the world. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071021/0ef372f0/attachment.pgp>