[FFmpeg-devel] [PATCH] better reporting of programs

[Reimar Döffinger]

Hello,
On Sat, Oct 20, 2007 at 08:27:45PM +0200, Michael Niedermayer wrote:
> On Wed, Oct 17, 2007 at 11:52:54PM +0200, Nico Sabbi wrote:
> > +                        AVFormatContext *ic = input_files[z];
> > +                        for(p=0; !found, p<ic->nb_programs; p++) {
> > +                            AVProgram *program = ic->programs[p];
> > +                            if(program->id == opt_programid) {
> > +                                for(q=0; !found, q<program->nb_stream_indexes; q++) {
> > +                                    int sidx = program->stream_index[q];
> > +                                    if(ic->streams[sidx]->codec->codec_type == ost->st->codec->codec_type) {
> > +                                        ost->source_index = file_table[z].ist_index + sidx;
> > +                                        found = 1;
> > +                                        break;
> 
> this is a classic case where goto should be used or it should be a seperate
> function which uses return

Given the indentation level I'd say an additional function wouldn't hurt...

Greetings,
Reimar D?ffinger