[FFmpeg-devel] [RFC] cryptokey options

[Baptiste Coudurier]

Hi

Reimar D?ffinger wrote:
> Hello,
> On Fri, Oct 19, 2007 at 03:00:20PM +0300, Kostya wrote:
>> On Fri, Oct 19, 2007 at 12:29:44PM +0200, Reimar D?ffinger wrote:
>>> I tried to implement this via a generic "binary" option type, but it
>>> does not seem to work, avfc->key stays NULL in the demuxer.
>>> Maybe that is just because I don't know how to use ffmpeg though...
>>> Fixes welcome.
>> Preserve original 'bin' variable pointer.
>> You seem to memcpy data _after_ decoded string.
> 
> Ouch, obviously. But that does not explain why key kept being NULL in
> the demuxer...
> 

I think problem is in opt_input_file:

 for(i=0; i<opt_name_count; i++){
        const AVOption *opt;
        double d= av_get_double(avformat_opts, opt_names[i], &opt);
        if(!isnan(d) && (opt->flags&AV_OPT_FLAG_DECODING_PARAM))
            av_set_double(ic, opt_names[i], d);
    }

Here av_get_double for cryptokey returns nan.

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
SMARTJOG S.A.                                    http://www.smartjog.com
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
Phone: +33 1 49966312