[FFmpeg-devel] [PATCH] better reporting of programs

[Michael Niedermayer]

On Wed, Oct 17, 2007 at 11:52:54PM +0200, Nico Sabbi wrote:
> Il Tuesday 16 October 2007 23:20:55 Michael Niedermayer ha scritto:
> 
> > wouldnt it be better to use the index (like in
> > AVFormatContext.streams[index]) or even a AVStream pointer
> > instead of AVStream.id ? it would be easier to find the AVStream
> > with the index/pointer, also finding the id from the index is a
> > mere .streams[index].id the other way around is slightly harder and
> > less efficient
> 
> implemented with an index
> 
> >
> > by how much would the complexity increas if this where (re)alloc()
> > instead of fixed 64 ?
> >
> > also the minor version should be bumped
> both done
> 
> > could you split the cosmetic code moving from the functional
> > changes?
> >
> > [...]
> 
> done.
> Patches are in this order:

> f1: cosmetical; moved the core of the stream description to a separate 
> function

ok


> f2: API extension

ok


> f3: actual use of the API in mpegts.c

iam not mpegts.c maintainer ...


> f4: changes to ffmpeg.c to support the programid switch
> (currently 1 program alone until Reimar implements the 
> code to assign arrays)

will review tomorrow

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The misfortune of the wise is better than the prosperity of the fool.
-- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071019/7440d761/attachment.pgp>