[FFmpeg-devel] [PATCH] don't arbitrarily prevent codec/muxer registering

[Aurelien Jacobs]

Diego Biurrun wrote:

> On Thu, Oct 18, 2007 at 10:58:54PM +0200, Aurelien Jacobs wrote:
> > 
> > I think there's no reason to arbitrarily prevent a compiled in codec/muxer
> > to register itself (if you don't want it to register, don't compile it in).
> > Attached patch ensure all compiled in codec/muxer are registered.
> > 
> > --- a/libavcodec/allcodecs.c
> > +++ b/libavcodec/allcodecs.c
> > @@ -190,8 +190,7 @@ void avcodec_register_all(void)
> >      REGISTER_ENCODER (LIBMP3LAME, libmp3lame);
> >      REGISTER_ENCODER (LIBTHEORA, libtheora);
> > -    if (!ENABLE_VORBIS_ENCODER)  REGISTER_ENCODER (LIBVORBIS, libvorbis);
> > -    if (!ENABLE_VORBIS_DECODER)  REGISTER_DECODER (LIBVORBIS, libvorbis);
> > +    REGISTER_ENCDEC  (LIBVORBIS, libvorbis);
> >      REGISTER_DECODER (MACE3, mace3);
> >      REGISTER_DECODER (MACE6, mace6);
> > --- a/libavformat/allformats.c
> > +++ b/libavformat/allformats.c
> > @@ -94,8 +94,7 @@ void av_register_all(void)
> >      REGISTER_DEMUXER  (IPMOVIE, ipmovie);
> >      REGISTER_DEMUXER  (LIBDC1394, libdc1394);
> > -    if (!ENABLE_NUT_DEMUXER) REGISTER_DEMUXER (LIBNUT, libnut);
> > -    if (!ENABLE_NUT_MUXER)   REGISTER_MUXER   (LIBNUT, libnut);
> > +    REGISTER_MUXDEMUX (LIBNUT, libnut);
> >      REGISTER_MUXDEMUX (M4V, m4v);
> >      REGISTER_MUXDEMUX (MATROSKA, matroska);
> 
> I think these are remnants from the times when the names of the native
> implementations clashed with the libraries.  I'd say commit.

Applied.
Now we can debate about whether we want to drop libvorbis support or not...
Anyone against removing it ?

Aurel