[FFmpeg-devel] [PATCH] don't arbitrarily prevent codec/muxer registering

[Aurelien Jacobs]

M?ns Rullg?rd wrote:

> Aurelien Jacobs <aurel at gnuage.org> writes:
> 
> > Hi,
> >
> > I think there's no reason to arbitrarily prevent a compiled in codec/muxer
> > to register itself (if you don't want it to register, don't compile it in).
> > Attached patch ensure all compiled in codec/muxer are registered.
> >
> > Aurel
> >
> > diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
> > index 90718dd..e86fc4e 100644
> > --- a/libavcodec/allcodecs.c
> > +++ b/libavcodec/allcodecs.c
> > @@ -190,8 +190,7 @@ void avcodec_register_all(void)
> >      REGISTER_ENCDEC  (LIBGSM_MS, libgsm_ms);
> >      REGISTER_ENCODER (LIBMP3LAME, libmp3lame);
> >      REGISTER_ENCODER (LIBTHEORA, libtheora);
> > -    if (!ENABLE_VORBIS_ENCODER)  REGISTER_ENCODER (LIBVORBIS, libvorbis);
> > -    if (!ENABLE_VORBIS_DECODER)  REGISTER_DECODER (LIBVORBIS, libvorbis);
> > +    REGISTER_ENCDEC  (LIBVORBIS, libvorbis);
> 
> Is there any reason we still have the libvorbis decoder wrapper at all?

I'm all for removing it, but as long as it don't get removed, I think this
patch should be applied.

Aurel