[FFmpeg-devel] [PATCH] better reporting of programs

Nico Sabbi nicola_sabbi
Wed Oct 17 23:52:54 CEST 2007


Il Tuesday 16 October 2007 23:20:55 Michael Niedermayer ha scritto:

> wouldnt it be better to use the index (like in
> AVFormatContext.streams[index]) or even a AVStream pointer
> instead of AVStream.id ? it would be easier to find the AVStream
> with the index/pointer, also finding the id from the index is a
> mere .streams[index].id the other way around is slightly harder and
> less efficient

implemented with an index

>
> by how much would the complexity increas if this where (re)alloc()
> instead of fixed 64 ?
>
> also the minor version should be bumped
both done

> could you split the cosmetic code moving from the functional
> changes?
>
> [...]

done.
Patches are in this order:
f1: cosmetical; moved the core of the stream description to a separate 
function
f2: API extension
f3: actual use of the API in mpegts.c
f4: changes to ffmpeg.c to support the programid switch
(currently 1 program alone until Reimar implements the 
code to assign arrays)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: f3.diff
Type: text/x-diff
Size: 889 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071017/95e81fc4/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: f2.diff
Type: text/x-diff
Size: 2650 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071017/95e81fc4/attachment-0001.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: f1.diff
Type: text/x-diff
Size: 3244 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071017/95e81fc4/attachment-0002.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: f4.diff
Type: text/x-diff
Size: 2891 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071017/95e81fc4/attachment-0003.diff>



More information about the ffmpeg-devel mailing list