[FFmpeg-devel] [PATCH] Fix apply_welch_window_sse2 compilation on Mac OS X/x86

[Reimar Döffinger]

Hello,
On Wed, Oct 17, 2007 at 10:29:30AM +0200, Pierre d'Herbemont wrote:
> Here is a fix for:
>
> i386/dsputil_mmx.c:3003: error: can't find a register in class 
> 'GENERAL_REGS' while reloading 'asm'
> i386/dsputil_mmx.c:3005: error: can't find a register in class 
> 'GENERAL_REGS' while reloading 'asm'
> make[4]: *** [i386/dsputil_mmx.o] Error 1
> make[3]: *** [lib] Error 2
> make[2]: *** [.ffmpeg] Error 2
> make[1]: *** [src] Error 2
>
> We don't have enough free registers around on Mac OS X/x86. Feel free to 
> commit a better fix.

Seems good to me, but someone must check the generated asm code if it is
either the same or at least not something slower on the systems where it
works currently (i.e. check that gcc does not something stupid like
reloading i and/or j).
Hm. On second thought. Why does gcc have a problem here? eax, ecx, edx,
esi, edi and ebp _should_ be available and that would be enough (when
compiling --disable-shared ebx would be available as well).
Or does -fomit-frame-pointer not work here for some reason (thus
allocating ebp)?

Greetings,
Reimar D?ffinger