[FFmpeg-devel] Bugreport: compiling fails with -fPIC used

[Thorsten Jordan]

Michael Niedermayer schrieb:
> On Tue, Oct 16, 2007 at 05:23:47PM +0200, Reimar D?ffinger wrote:
>> Hello,
>> IIRC you normally can't use push/pop as gcc might use esp/rsp relative
>> addressing for arguments. In this case it might work since all
>> constraints are "r", but it still seems risky to meddle with the stack
>> without letting gcc know.
> iam more concerned by the direct use of ebx without having ebx on the
> clobber list or anywhere else "reserved"
> this code is just plain wrong
you are right, it is hackish. It can be done better my using direct
register names. I don't know if that is welcome, at least the following
patch is better in that case.

The second change further down the file is in a second patch.

-- 
Greetings, Thorsten
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dsputil_mmx_fPIC_compat-1.patch
Type: text/x-patch
Size: 1715 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071017/b7cd5c01/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dsputil_mmx_fPIC_compat-2.patch
Type: text/x-patch
Size: 2081 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071017/b7cd5c01/attachment-0001.bin>