[FFmpeg-devel] [PATCH] Proposal: undefine DEBUG_SEEK in libavformat/utils.c

[Benoit Fouet]

Michael Niedermayer wrote:
> Hi
>
> On Tue, Oct 16, 2007 at 11:26:01AM +0200, Benoit Fouet wrote:
>   
>> Benoit Fouet wrote:
>>     
>>> Michael Niedermayer wrote:
>>>   
>>>       
>>>> Hi
>>>>
>>>> On Mon, Oct 15, 2007 at 02:52:36PM +0200, Thorsten Jordan wrote:
>>>>   
>>>>     
>>>>         
>>>>> Hallo,
>>>>>
>>>>> the attached patch does $subj. While test code is a good idea, it
>>>>> shouldn't be needed for production code. The define leads to intensive
>>>>> seeking in transport streams at line 1241ff if DEBUG_SEEK is defined.
>>>>>     
>>>>>       
>>>>>           
>>>> patch ok
>>>>
>>>>   
>>>>     
>>>>         
>>> Applied
>>>
>>>   
>>>       
>> this breaks seek regression test (i missed that) as follows, what should
>> be done ?
>>     
>
> hmm, revert and wait for an explanation of the (poor) patch author
> its his patch he has to explain why that happens if he wants the patch
> applied :)
>
>   

ok, done

-- 
Ben