[FFmpeg-devel] [PATCH] NellyMoser audio decoder v2

[Vitor Sessak]

Hi

Just some nitpicking...

Benjamin Larsson wrote:
> Michael Niedermayer wrote:
> 
> static inline int signed_shift(int i, int shift) {
>     if (shift > 0) {
>         return i << shift;
>     }

Indentation in the patch is inconsistent between

if (a) {
     b;
}

and

if (a)
     b;

I personally prefer the latter.

> 
> AVCodec nellymoser_decoder = {
>     "nellymoser",
>     CODEC_TYPE_AUDIO,
>     CODEC_ID_NELLYMOSER,
>     sizeof(NellyMoserDecodeContext),
>     decode_init,
>     NULL,
>     decode_end,
>     decode_tag,
>     0,
> };

This 0 is useless.

-Vitor