[FFmpeg-devel] [PATCH] Add SLIB_UNINSTALL_EXTRA_CMD to build system.

[Diego Biurrun]

On Tue, Oct 09, 2007 at 07:14:47PM -0700, Dave Yeo wrote:
> ...
> I've attached a quick untested patch for mingw, should uninstall the
> same lib installed by SLIB_INSTALL_EXTRA_CMD. Though I am somewhat confused 
> as I thought the SLIB_INSTALL_EXTRA_CMD was installing an import lib yet it 
> seems to be installing the DLL with a .lib suffix instead of .dll. Also it 
> looks like gcc is creating an import lib with the suffix of .dll.a which is 
> not installed.
> Kept to the same style as used in the rest of mingw section of configure.
> Also cygwin has similar behaviour, looks like it creates an import lib but 
> never installs it.
> Do both cygwin and mingw allow directly linking against DLLs and if so what 
> is the point of creating import libs and in mingw case installing the DLL 
> with a lib suffix?
> Guess its time to fix my Windows install :)

Some of the Windows people will have to comment on this..

> --- configure	(revision 10693)
> +++ configure	(working copy)
> @@ -1184,6 +1184,7 @@
>      SLIBNAME_WITH_MAJOR='$(SLIBPREF)$(NAME)-$(LIBMAJOR)$(SLIBSUF)'
>      SLIB_EXTRA_CMD="-lib /machine:i386 /def:\$(@:${SLIBSUF}=.def)"
>      SLIB_INSTALL_EXTRA_CMD="-install -m 644 \$(SLIBNAME_WITH_MAJOR:\$(SLIBSUF)=.lib) \"\$(SHLIBDIR)/\$(SLIBNAME_WITH_MAJOR:\$(SLIBSUF)=.lib)\""
> +    SLIB_UNINSTALL_EXTRA_CMD="rm -f \$(SHLIBDIR)/\$(SLIBNAME_WITH_MAJOR:\$(SLIBSUF)=.lib)"
>      SHFLAGS="-shared -Wl,--output-def,\$(@:${SLIBSUF}=.def),--out-implib,lib\$(SLIBNAME:\$(SLIBSUF)=.dll.a) -Wl,--enable-runtime-pseudo-reloc -Wl,--enable-auto-image-base"

This does not apply anymore.  Also, you can save some of the backslashes
by using single quotes.

> --- common.mak	(revision 10693)
> +++ common.mak	(working copy)
> @@ -97,6 +97,7 @@
>  	       "$(SHLIBDIR)/$(SLIBNAME)"            \
>  	       "$(SHLIBDIR)/$(SLIBNAME_WITH_VERSION)"
>  	-rm -f "$(LIBDIR)/$(LIB)"
> +	$(SLIB_UNINSTALL_EXTRA_CMD)

This belongs one line up along with the other shared lib uninstall
stuff.

Looks OK otherwise.

Diego