[FFmpeg-devel] [PATCH] Fix memleak in lavf/asf.c

[Michael Niedermayer]

On Thu, Oct 11, 2007 at 08:32:19PM -0300, Ramiro Polla wrote:
>   wrote:
> > Ramiro Polla <ramiro at lisha.ufsc.br> writes:
> > 
> >> Hello,
> >>
> >> $subj
> >>
> >> issue102: https://roundup.mplayerhq.hu/roundup/ffmpeg/issue102
> >>
> >> Ramiro Polla
> >> Index: libavformat/asf.c
> >> ===================================================================
> >> --- libavformat/asf.c	(revision 10710)
> >> +++ libavformat/asf.c	(working copy)
> >> @@ -884,6 +884,8 @@
> >>
> >>      for(i=0;i<s->nb_streams;i++) {
> >>          AVStream *st = s->streams[i];
> >> +        ASFStream *asf_st= st->priv_data;
> > 
> > Please put a space before the = sign if you have one after, which I
> > think you should.
> 
> I just copy&pasted from somewhere on the same file. I'll take it into 
> account after a proper review.

so you duplicated some code?
no please rather call that reset function instead of copiing a random
subset ...


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Asymptotically faster algorithms should always be preferred if you have
asymptotical amounts of data
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071012/6dd1b1eb/attachment.pgp>