[FFmpeg-devel] [PATCH] MLP/TrueHD decoder

[Diego Biurrun]

On Fri, Oct 12, 2007 at 01:29:46PM +0100, Ian Caulfield wrote:
> 
> I've been working for a while on reverse engineering the MLP audio
> stream format, and writing my own decoder. I've finally got to a point
> where I have something ready for review. I'm going to try to get the
> documentation I've produced on the format up on the multimediawiki as
> well.

New decoders are always very much welcome :)

> Comments welcome :)
> 
> --- libavcodec/mlp_parser.c	(revision 0)
> +++ libavcodec/mlp_parser.c	(revision 0)
> @@ -0,0 +1,338 @@
> +/*
> + * MLP parser
> + * Copyright (c) 2007 Ian Caulfield.

nit: This period is useless.

> +/**
> + * @file mlp_parser.c
> + * MLP parser.

ditto

> --- libavcodec/mlp_parser.h	(revision 0)
> +++ libavcodec/mlp_parser.h	(revision 0)
> @@ -0,0 +1,53 @@
> +/*
> + * MLP parser prototypes
> + * Copyright (c) 2007 Ian Caulfield.

ditto

> +/**
> + * @file mlp_parser.h
> + * MLP parser prototypes.

ditto, same in the other patch

A slightly more useful comment: The header file needs multiple
inclusion guards.

The build system part of the patch is OK.

Diego