[FFmpeg-devel] [PATCH] deinterlace for GRAY8 images

[Michael Niedermayer]

Hi

On Fri, Oct 12, 2007 at 12:37:04AM +0200, Michael Niedermayer wrote:
> On Thu, Oct 11, 2007 at 11:30:45PM +0100, M?ns Rullg?rd wrote:
> > Michael Niedermayer <michaelni at gmx.at> writes:
> > 
> > > Hi
> > >
> > > On Wed, Oct 10, 2007 at 12:00:43PM +0200, Andrea Gualano wrote:
> > >> Hi,
> > >>
> > >> This trivial patch enables avpicture_deinterlace() for images whose
> > >> pixel format is PIX_FMT_GRAY8 and runs the deinterlacing algorithm on
> > >> the first (and only) field.
> > >
> > > ok
> > 
> > What magic does PIX_FMT_GRAY8 possess that such images cannot be
> > interlaced like any other?
> 
> the patch only skips the deinterlacing of the chroma planes for GRAY8
> which does not work that well ...

looking at this again, it would be cleaner to use
pix_fmt_info[].nb_channels==3 instead of !=PIX_FMT_GRAY8

also avcodec_get_chroma_sub_sample() should be used instead of the
swictch/case but that has nothing to do with the patch ...
and the whole imgconvert would need a cleanup if it wasnt sheduled
for replacement by libavfilter and if there wouldnt be so much better
and faster deinterlacing filters which should be ported to libavfilter
...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored awnser#1 FFmpeg bugs should be sent to our bugtracker, user
questions for the command line tools ffmpeg, ffplay, ... as well as questions
about how to use libav* should be sent to the ffmpeg-user mailinglist.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071012/f9d5f64e/attachment.pgp>