[FFmpeg-devel] [PATCH] support encrypted asf

[Reimar Döffinger]

Hello,
On Tue, Oct 09, 2007 at 10:05:38PM +0300, Uoti Urpala wrote:
[...]
> +    // uses a fixpoint-iteration to find the inverse very quickly
> 
> Explicitly mentioning that it's fixed point is not useful IMO.

Am I the only one two whom fixpoint and fixed point mean completely
different things?

> +    int i = 3;
> +    do {
> +        inverse *= 2 - v * inverse;
> +    } while (--i);
> 
> I'd just repeat the line 3 times instead of using a loop.

It seemed clearer to me, though I added it when it was still 5 steps...

> If you do want to use a loop using "for" would be clearer (any compiler
> should be able to optimize that loop to equal code).

I agree "for" would probably be better. But gcc in my experience does
not convert a for loop into and equivalent do {} while that will use the
Z-flag. It is somewhat moot, since in this case (at least my) gcc
completely unrolls the loop even at -O1.

Greetings,
Reimar D?ffinger