[FFmpeg-devel] [PATCH] Implement PAFF in H.264

Michael Niedermayer michaelni
Sun Oct 7 22:37:53 CEST 2007


On Fri, Oct 05, 2007 at 02:23:48PM -0400, Jeff Downs wrote:
[...]
> > [...]
> > > +        } else {
> > > +            av_log(h->s.avctx, AV_LOG_ERROR, "problem in internal reference "
> > > +                                             "list handling; marking second "
> > > +                                             "field in pair finds first field "
> > > +                                             "in reference, but not in any "
> > > +                                             "ref list\n");
> > 
> > if this cannot happen unless our code is buggy te correct behavior is
> > assert(0);
> 
> OK. Added the assert, changed the log message to a comment, removed the 
> reference clearing. The block will be a no-op when NDEBUG is defined.
> 
> Revised patch attached.
> 
> If ok, I'll follow up with revised indent patch to match prior to 
> application in svn.

patch looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071007/cbcc9026/attachment.pgp>



More information about the ffmpeg-devel mailing list