[FFmpeg-devel] [PATCH] faad2 version 2.5 support

[Rich Felker]

On Sun, Oct 07, 2007 at 10:19:04AM -0700, Frank Liu wrote:
> On 10/7/07, Rich Felker <dalias at aerifal.cx> wrote:
> > On Sat, Oct 06, 2007 at 03:01:42AM +0300, Ivan Kalvachev wrote:
> > > 2007/10/6, Frank Liu <gfrankliu at gmail.com>:
> > > [...]
> > > >
> > > > If I apply my patch and rebuild ffmpeg, same command runs without any errors.
> > > >
> > > > Thoughts?
> > >
> > > I think your patch would break building of the older FAAD (FAAC?) versions.
> > > Some people still prefer the old version because license changes by
> > > Nero rendered the library GPL incompatible.
> >
> > IMO we should explicitly reject new versions rather than being
> > compatible with both.
> >
> 
> If you want to "reject", the easiest solution is to patch the
> configure to default enable libfaadbin when libfaad is enabled. As I

faadbin does not reject non-free faad. Also it's not universally
available.

Rich