[FFmpeg-devel] [PATCH] Implement PAFF in H.264

[Andreas Öman]

Hi,

Michael Niedermayer wrote:
> Hi
> 
>> @@ -6666,7 +6673,7 @@
>>                  s->mb_x = 0;
>>                  ff_draw_horiz_band(s, 16*s->mb_y, 16);
>>                  ++s->mb_y;
>> -                if(FRAME_MBAFF) {
>> +                if(FRAME_MBAFF || FIELD_PICTURE) {
> 
> this really should be FRAME_MBAFF_OR_FIELD or something like that

Michael, correct me if i'm wrong here, but isn't this already in
place?

h264.h: #define MB_FIELD h->mb_field_decoding_flag

And h->mb_field_decoding_flag is already correctly computed,
both for MBAFF and PAFF, in the beginning of decode_mb_cabac()
and decode_mb_cavlc().


> also i think it would be better if you would post 1 patch per email
> instead of many as later can get quite confusing for everyone if 
> some are approved some are not and some arent revied yet ...

Agree here...