[FFmpeg-devel] [PATCH] replace ogg seek function by read_timestamp and generic seek

[Måns Rullgård]

Rich Felker wrote:
> On Wed, Oct 03, 2007 at 03:53:43PM +0100, M?ns Rullg?rd wrote:
>> > mplayer you should use -nocache, because the cache implementation sucks
>> > and thus seeking might almost take a second with it set to 10 MB.
>> > And I am not really looking at the ogg demuxer but only at issue 159 ;-)
>> > (not to mention that I was never really a fan of
>> > seeking-only-to-keyframes which I guess this is supposed to fix).
>>
>> That change makes the demuxer report keyframes for Theora and OGM
>> streams.  It doesn't do anything with the information.  What is the
>> preferred way of implementing seeking to keyframes nowadays?  Rich
>> was complaining about the Ogg demuxer not doing this yesterday on IRC.
>
> Shouldn't the generic binary search code handle using the keyframe
> information?

That would of course be reasonable, but I can't see that it's being
done.

-- 
M?ns Rullg?rd
mans at mansr.com