[FFmpeg-devel] [PATCH] Add a priv_data pointer to?AVFormatParameters

[Reimar Döffinger]

Hello,
On Wed, Oct 03, 2007 at 03:24:29PM +0100, Andy Parkins wrote:
> On Wednesday 2007 October 03, Michael Niedermayer wrote:
> > > The solution is this patch; we add a priv_data pointer to
> > > AVFormatParameters.  AVFormatParameters is created filled with NUL bytes
> > > by default so if the user chooses not to supply priv_data, the custom
> > > read_header() will receive a NULL priv_data pointer.
> >
> > rejected
> 
> Okay, it's not problem to me.  Although I think you're rejecting it because 
> you think I'm on a secret mission to create a new muxer format that I'm not 
> going to share.  Is there some technical reason you're rejecting it?  I'd be 
> happy to try and "do it the right way", if that's possible.

Well, I'd says the technical reason is "what's the point"? This is only
useful for demuxers not included in SVN, so the ffmpeg project does not
win anything except a pointer that avoid misuse (e.g. some horrible
out-of-band commmunication).
For those who use it, what do they win? The save having to maintain that
one-line patch while still having to maintain the additional demuxer
code, which I'd call "nothing".

Greetings,
Reimar D?ffinger