[FFmpeg-devel] [PATCH] pointless #ifdeffery in mpegvideo_ppc.c

Diego Biurrun diego
Tue Oct 2 12:54:28 CEST 2007


On Tue, Oct 02, 2007 at 12:30:12PM +0200, Diego Biurrun wrote:
> On Tue, Oct 02, 2007 at 12:12:15PM +0200, Luca Barbato wrote:
> > Diego Biurrun wrote:
> > > On Tue, Oct 02, 2007 at 10:39:01AM +0200, Diego Biurrun wrote:
> > >> This patch removes some pointless #ifdefs from
> > >> libavcodec/ppc/mpegvideo_ppc.c and makes the file conditional on
> > >> HAVE_ALTIVEC.  It only contains AltiVec code anyway.  Alternatively, or
> > >> as a next step, it could be directly merged into mpegvideo_altivec.c.
> > 
> > fine, I'm about to commit something more invasive about moving all
> > altivec bits in the same place...
> 
> OK, I have committed my patch as a first step.  Do you agree we should
> move the code into mpegvideo_altivec.c now?

Here is the patch.  The ugly extern declarations could possibly be
avoided by creating idct_altivec.h as a next step.

Diego
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ppc.patch
Type: text/x-diff
Size: 2482 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071002/69fc6de4/attachment.patch>



More information about the ffmpeg-devel mailing list