[FFmpeg-devel] [PATCH] Fix redirector implementation

Michael Niedermayer michaelni
Wed Nov 28 20:11:03 CET 2007


Hi

On Wed, Nov 28, 2007 at 04:24:42PM +0100, Luca Abeni wrote:
> Hi Michael,
>
> Michael Niedermayer wrote:
> [...]
>>> I am thinking about a more radical approach: basically, doing a
>>> *s = *ic;
>>> at the end of redir_read_header()... Do you see any obvious problems with 
>>> it?
>> no but that doesnt say much, there still could be obvious problems :)
>>> I am going to test this idea, and will send a patch this afternoon.
>> ok
>
> And here is the patch... It's even simpler than the first one :)
> Tested with ffserver's redirection from http to rtsp, and it works.
>
> I tried to detect memory leaks with mtrace(), and there are no changes
> respect to ffmpeg from svn (mtrace shows some "non freed" memory on
> unpatched ffmpeg. I did not investigate this, but maybe it is expected).

patch looks ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071128/3b346926/attachment.pgp>



More information about the ffmpeg-devel mailing list