[FFmpeg-devel] [RFC] Split libavformat

[Michael Niedermayer]

Hi

On Tue, Nov 27, 2007 at 06:34:09PM +0100, Michael Niedermayer wrote:
[...]
> > resolve_host[_ipv6]() isn't an os_support function and would move to
> > network.c (new). 
> 
> it seems you dont get it, lavf WILL NOT provide an externally vissible 
> resolve_host() no matter what API or implementation, ffserver seems to need
> it though

s/an externally vissible resolve_host()/resolve_host() as part if its public API/

(if ffserver uses it, it has to be part of the pubic API ...)


> 
> 
> > Imo, ff_socket_nonblock() could move as static inline to
> > network.h (even though the implementation is different in the win-case, I
> > don't think it justifies itself being in a "OS support" library, because
> > it's not a missing function in that OS; it is just implemented differently,
> > kind of like BE vs. LE).
> 
> no form of an externally vissible ff_socket_nonblock() does belong into lavf
> tcp.c as well as ffserver.c need it
> duplication is not ok, and a static in a header would be duplication as well

same here, i used bad wording, i meant of course public API not just
externally vissible
but ff_socket_nonblock() is used by ffserver.c so it isnt really an internal
function

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071127/bd6cd880/attachment.pgp>