[FFmpeg-devel] [PATCH] IPv6 support v.2

[Michael Niedermayer]

On Mon, Nov 26, 2007 at 04:56:47PM +0100, Luca Abeni wrote:
> Hi Ronald,
> 
> Ronald S. Bultje wrote:
[...]
> > In the end, a lot of things and various ways to go, since I did 3 approaches
> > so far (uses error code from gethostbyname, switch to gethostbyname_r and
> > switch to getaddrinfo in a wrapper) and none of them got me anywhere, I'd
> > like a clear path for me before I start, I'm not going to waste another
> > month on these patches and see them rejected again.
> 
> Maybe the point is that we should proceed by small steps:
> 1) ensure that the "getaddrinfo" code works well on the most used OSs (hint:
>     mingw seems to provide getaddrinfo(), but the configure script is not able
>     to detect it, and when compiling with mingw CONFIG_IPV6 is disabled).
> 2) remove the IPV4-only code from udp.c
> 3) wait some time, and see if people complain. Implement a getaddrinfo replacement
>     in an external library (maybe the libossupport - or whatever is the name -

libossupport is a nice name :)


>      that Michael is requesting?),

iam not requesting it, i just strongly think that os_support.* and all
similar hacks belong into a lib different from libav*
if you can change the code so os_support.* is no longer needed and it still
works on all platforms where it did work before then thats perfectly fine as
well


>     for the (hopefully few) systems that do not provide it.
>     Someone said that this should be fairly easy... Maybe he can provide some help on this?
> 4) convert tcp.c
> 5) convert rtsp.c and sdp.c
> 6) fix ffserver.c
> 
> Again, this is just my opinion. I do not want to force anyone to follow it.
> If people agree that this is the way to go, I can help following the path I
> indicated.

i agree in general with it but id be more evil and just disable the IPV4 code
instead of "ensure that the "getaddrinfo" code works well ..." that is if it
works on your system ...

the problem is that very few people will test the getaddrinfo() code as long
as they "dont have to"
the same is true with fixing the ipv* code, if it doesnt work people just use
the v4 code, if theres no v4 code they are much more likely to submit a patch

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

There will always be a question for which you do not know the correct awnser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071126/7b7f45d9/attachment.pgp>