[FFmpeg-devel] [PATCH][1/4] URLProtocol extensions
Mon Nov 26 14:09:41 CET 2007
On Fri, 2007-11-23 at 22:31 +0100, Diego Biurrun wrote:
> On Fri, Nov 23, 2007 at 02:19:03PM +0000, Bj?rn Axelsson wrote:
> > On Thu, 2007-11-22 at 19:12 +0100, Michael Niedermayer wrote:
> > > On Thu, Nov 22, 2007 at 02:49:01PM +0000, Bj?rn Axelsson wrote:
> > > > Extend URLProtocol with new function pointers and api functions for
> > > > url_read_play(), url_read_pause() and url_read_seek().
> > >
> > > please give the functions some prefix like av_
> > > doing something stupid because the code is then consistently stupid
> > > does not seem like a very good idea IMHO ;)
> > Argh. Inconsistency vs stupidity is not a fun choice. How about
> > prefixing all the avio functions with "av_" once and for all while we
> > are still close to a major version increase?
> Patches welcome :)
Challenge accepted ;)
Attached is a small and stupid shell script that prefixes most functions
in avio. I didn't attach the 600k (100k compressed) patch it generates,
but I can do that if requested.
The modified code passes "make test".
The missing functions (url_open, url_read, url_write, url_seek,
url_close) need to be changed manually, but I can do that if someone
actually thinks this is a good idea.
Also, this change messes up many vertical alignments, something that I
have no intention of fixing manually...
Bj?rn Axelsson Phone: +46-(0)90-18 98 97
Intinor AB Fax: +46-(0)920-757 10
Interactive Television & Digital Media Distribution
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 1360 bytes
Desc: not available
More information about the ffmpeg-devel