[FFmpeg-devel] [PATCH] RV30/40 decoder

[Michael Niedermayer]

On Sat, Nov 24, 2007 at 05:45:21PM +0200, Kostya wrote:
[...]
> [...]
> > > +/**
> > > + * Table for obtaining quantizer difference
> > > + */
> > > +static const int8_t rv34_dquant_tab[] = {
> > > +  0,  0,  2,  1, -1,  1, -1,  1, -1,  1, -1,  1, -1,  1, -1,  1,
> > > + -1,  1, -1,  1, -1,  1, -2,  2, -2,  2, -2,  2, -2,  2, -2,  2,
> > > + -2,  2, -2,  2, -2,  2, -2,  2, -2,  2, -3,  3, -3,  3, -3,  3,
> > > + -3,  3, -3,  3, -3,  3, -3,  3, -3,  3, -3,  2, -3,  1, -3, -5
> > > +};
> > 
> > isnt this the same as modified_quant_tab ?
> 
> Yes, it could be used instead (if it was not static)

well you could change it to be non static, theres also a second table
IIRC which could be used from h263something.h

either way, even if we decide that the dependancy on h263 is too much
of an annoyance to share the table, it at least should be changed to
be binary identical its simpler code wise (1 add less) and
the linker might be able to remove the duplicate table ...

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20071124/a5ea0470/attachment.pgp>